This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Enable copy picture only in contenteditable #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch the error raised by 'check_call' rather than the error emitted by
the called process.
BUG=chromium:460693,chromium:459681
TEST=local
- Ran without fix, setting CHROME_HEADLESS=1. Script failed with the exception
in the bug.
- Ran with fix, 'gsutil' failed with AccessDeniedException output
and the calling script successfully emitted a warning message.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/949813002
Cr-Commit-Position: refs/heads/master@{#317608}
(cherry picked from commit 63ab4fe)
Review URL: https://codereview.chromium.org/953803002
Cr-Commit-Position: refs/branch-heads/2311@{#11}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
By default Skia blends the source and destination buffers when drawing an image. This forces it to copy the source buffer to the modeset buffer. BUG=455605 Review URL: https://codereview.chromium.org/948903003 Cr-Commit-Position: refs/heads/master@{#317691} (cherry picked from commit 38ad735) Review URL: https://codereview.chromium.org/956553003 Cr-Commit-Position: refs/branch-heads/2311@{#13} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
DRM devices such as VGEM do not have resources, so we want to ignore them rather than crash. BUG=460982 Review URL: https://codereview.chromium.org/947293002 Cr-Commit-Position: refs/heads/master@{#317687} (cherry picked from commit 3b2bde2) Review URL: https://codereview.chromium.org/956563004 Cr-Commit-Position: refs/branch-heads/2311@{#14} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Show menu item to view original image if the request could go over the data reduction proxy. BUG=456247 Review URL: https://codereview.chromium.org/944533002 Cr-Commit-Position: refs/heads/master@{#317720} (cherry picked from commit f28021f) Review URL: https://codereview.chromium.org/953053003 Cr-Commit-Position: refs/branch-heads/2311@{#16} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
[email protected] TBR=tnagel NOTREECHECKS=true BUG=451073 Review URL: https://codereview.chromium.org/949173004 Cr-Commit-Position: refs/branch-heads/2311@{#17} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…ents with a delay, as for ExtensionHosts. extensions::ProcessManager starts ExtensionHosts asynchronously with a queue to avoid using too much resources at startup; make BackgroundContentsService use the same queue implementation. (ExtensionHostQueue now accepts an interface that both BackgroundContentsService and ExtensionHost share.) This significantly reduces the time BackgroundContentsService contributes to ExtensionService startup (75th percentile was ~300ms, according to Extensions.BackgroundContentsServiceStartupTime). BUG=47236 Review URL: https://codereview.chromium.org/933423003 Cr-Commit-Position: refs/heads/master@{#317480} (cherry picked from commit d61dfe1) Review URL: https://codereview.chromium.org/955713004 Cr-Commit-Position: refs/branch-heads/2311@{#18} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
The performance is horrendous, so let's disable the animations for each of the menu items for now as it looks 90% as good as a well performing animation on newer builds of android. BUG=428477 Review URL: https://codereview.chromium.org/948183003 Cr-Commit-Position: refs/heads/master@{#317692} Review URL: https://codereview.chromium.org/927103003 Cr-Commit-Position: refs/branch-heads/2311@{#19} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Will merge this to M42, then revert on trunk. BUG=460900 Review URL: https://codereview.chromium.org/949753006 Cr-Commit-Position: refs/heads/master@{#317638} (cherry picked from commit 0d59aea) Review URL: https://codereview.chromium.org/948343005 Cr-Commit-Position: refs/branch-heads/2311@{#20} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Simply hide the Autofill/Wallet preferences. The correct fix will involve checking the state of the sync experiment, but for M42 it's enough to just disable this preference page. Will require merge to m42. BUG=460900 [email protected] Review URL: https://codereview.chromium.org/947253002 Cr-Commit-Position: refs/heads/master@{#317699} (cherry picked from commit 652772c) Review URL: https://codereview.chromium.org/947333003 Cr-Commit-Position: refs/branch-heads/2311@{#21} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
BUG=430328 Review URL: https://codereview.chromium.org/943103002 Cr-Commit-Position: refs/heads/master@{#317489} (cherry picked from commit 01f8886) Review URL: https://codereview.chromium.org/955843002 Cr-Commit-Position: refs/branch-heads/2311@{#22} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Enables PushManager.hasPermission() as a transition until the Permissions API can be used in order to get that information. It will save a lot of trouble in changing the current test in order to no longer use hasPermission() then change them again to use the Permissions API. This is a three sided CL: 1- https://codereview.chromium.org/926793004 2- <this> 3- https://codereview.chromium.org/936873002 BUG=449178 [email protected],[email protected] Review URL: https://codereview.chromium.org/937563004 Cr-Commit-Position: refs/heads/master@{#317512} (cherry picked from commit 6aa6126) Review URL: https://codereview.chromium.org/950723003 Cr-Commit-Position: refs/branch-heads/2311@{#23} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Return the y coordinate of the PopupTouchHandleDrawable position when it is requested. Turns out, returning the x coordinate is bad. BUG=461598 Review URL: https://codereview.chromium.org/931283008 Cr-Commit-Position: refs/heads/master@{#317936} (cherry picked from commit 048b41f) Review URL: https://codereview.chromium.org/952263002 Cr-Commit-Position: refs/branch-heads/2311@{#24} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…wn (patchset #9 id:350001 of https://codereview.chromium.org/900063002/) Reason for revert: Causes regression in cold start on Android and maybe Mac. Details in http://crbug.com/457248. Original issue's description: > Fixes for two different HUD issues related to win32k lockdown > > 1. Using a GDI bitmap -- switch to SkSurface instead > > 2. Lazily loading a font. This breaks for two different reasons. > The first is a DCHECK for doing IO on the Compositor thread. This > could have been just ignored in general since it's only for debug > usage, the drawbacks of minor jank are limited. > > However, once lockdown is on, the font load hard fails from the > renderer. So, load the typeface before lockdown and pass it into > CC and the hud via LayerTreeSettings. > > [email protected] > BUG=453731,455104 > TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8 > > Committed: https://crrev.com/616a8e656b2d923ed393bde86adc150e555ba799 > Cr-Commit-Position: refs/heads/master@{#314929} [email protected],[email protected],[email protected] BUG=453731,455104,457248 Review URL: https://codereview.chromium.org/922293006 Cr-Commit-Position: refs/heads/master@{#317648} (cherry picked from commit 1793e04) Review URL: https://codereview.chromium.org/951423003 Cr-Commit-Position: refs/branch-heads/2311@{#25} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
The new icons are slightly larger than the previous version, per the feedback we received from various reviews. [email protected], [email protected] BUG=460042 Review URL: https://codereview.chromium.org/946673002 Cr-Commit-Position: refs/heads/master@{#317576} (cherry picked from commit e7a4e69) Review URL: https://codereview.chromium.org/950903005 Cr-Commit-Position: refs/branch-heads/2311@{#26} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…nabled Previously streams would be intercepted even if the MimeHandlerView plugin associated with them was disabled which would prevent the resource from being download if a plugin wasn't being enabled to handle it. BUG=459383 Review URL: https://codereview.chromium.org/933093002 Cr-Commit-Position: refs/heads/master@{#317673} (cherry picked from commit 553cec8) Review URL: https://codereview.chromium.org/957703005 Cr-Commit-Position: refs/branch-heads/2311@{#27} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Non-existent dictionary members were trying to be accessed. BUG=461587 Review URL: https://codereview.chromium.org/959443003 Cr-Commit-Position: refs/heads/master@{#317935} (cherry picked from commit 7593306) Review URL: https://codereview.chromium.org/958763002 Cr-Commit-Position: refs/branch-heads/2311@{#29} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
For plugins listed in chrome/browser/resources/plugin_metadata/plugins_*.json, the resource identifier for that plugin becomes the key used in those JSON files. Previously, the PDF plugin filename was used as the resource identifier to whitelist the PDF plugin within the PDF extension. This caused the whitelisting to be ineffective for official builds and also other builds after r316957 added an entry for the Chromium PDF Viewer plugin. This CL fixes this by using the keys from the plugin metadata files as the resource identifiers for whitelisting the PDF plugin. BUG=459998 Review URL: https://codereview.chromium.org/946293002 Cr-Commit-Position: refs/heads/master@{#317556} (cherry picked from commit 2c8ef92) [email protected] Review URL: https://codereview.chromium.org/956163002 Cr-Commit-Position: refs/branch-heads/2311@{#30} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
> BUG=461408 > > Review URL: https://codereview.chromium.org/952833005 > > Cr-Commit-Position: refs/heads/master@{#317882} > (cherry picked from commit a1f4fa3) [email protected] Review URL: https://codereview.chromium.org/960093002 Cr-Commit-Position: refs/branch-heads/2311@{#31} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…fetched. Before, we were not notifying Files app about such fact, so it was still thinking that Drive is not available, and showing the banner. [email protected] # For merge. TEST=Tested manually when logging to an empty profile. BUG=461247 Review URL: https://codereview.chromium.org/953273002 Cr-Commit-Position: refs/heads/master@{#317995} (cherry picked from commit eaffcdb) Review URL: https://codereview.chromium.org/961593002 Cr-Commit-Position: refs/branch-heads/2311@{#32} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
BUG=446263,457482 Review URL: https://codereview.chromium.org/945063002 Cr-Commit-Position: refs/heads/master@{#317483} (cherry picked from commit cd52b1d) Review URL: https://codereview.chromium.org/960793002 Cr-Commit-Position: refs/branch-heads/2311@{#33} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
This CL fixes focus regression introduced in https://codereview.chromium.org/908033005 BUG=450465 TEST=manual Review URL: https://codereview.chromium.org/951783003 Cr-Commit-Position: refs/heads/master@{#317777} (cherry picked from commit 2672bd9) Review URL: https://codereview.chromium.org/962523004 Cr-Commit-Position: refs/branch-heads/2311@{#34} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…supervised node. The title can actually change when switching to a different translation, which would trigger a NOTREACHED in BookmarkModel::SetTitle. BUG=459448 Review URL: https://codereview.chromium.org/946363002 Cr-Commit-Position: refs/heads/master@{#317587} (cherry picked from commit 2d81cac) TBR=amineer Review URL: https://codereview.chromium.org/961613002 Cr-Commit-Position: refs/branch-heads/2311@{#35} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
F13 - F15 in particular are needed for lock, key help, and diamond keys on extended ChromeOS keyboards. BUG=454865 Review URL: https://codereview.chromium.org/934003002 Cr-Commit-Position: refs/heads/master@{#317902} (cherry picked from commit 5ee26af) TBR=Wez,spang Review URL: https://codereview.chromium.org/961843002 Cr-Commit-Position: refs/branch-heads/2311@{#36} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
This closes two large holes in the settings code:
(1) Any changes made before the input device thread starts are lost.
(2) Settings are not internally applied to new devices on hotplug.
In theory these problems should not have mattered because there is a
DeviceChangeHandler class to watch for new devices & reapply settings
whenever a new device appears. However, in practice that class is not
actually instantiated. We've had several reports of settings not being
properly applied.
To fix (1) build up desired settings state on the UI thread in
InputControllerEvdev, and push it to InputDeviceFactoryEvdev once the
thread starts.
To fix (2) keep the desired settings state on InputDeviceFactoryEvdev,
and reapply settings on hotplug.
BUG=451743
TEST=Turned on australian scrolling & ran "sudo restart udev" on
link_freon. Verified scrolling is still australian.
Review URL: https://codereview.chromium.org/951063004
Cr-Commit-Position: refs/heads/master@{#317851}
(cherry picked from commit 8ec6aaa)
Review URL: https://codereview.chromium.org/956793002
Cr-Commit-Position: refs/branch-heads/2311@{#37}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
- Fix the task queue so that cancelling a task doesn't leave it hanging out in the queue, which then will jam everything up. - Fix the error code so that errors are handled consistently (and are non-terminal, as they should be) - Rename UpdateType.SUCCESS to UpdateType.COMPLETE. This better reflects the fact that errors can occur during an import task but the task still runs to completion. BUG=460597 Review URL: https://codereview.chromium.org/947583002 Cr-Commit-Position: refs/heads/master@{#317538} (cherry picked from commit fb5551a) TBR=mtomasz Review URL: https://codereview.chromium.org/964533003 Cr-Commit-Position: refs/branch-heads/2311@{#38} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
The old Chromoting code (policy_hack before crrev.com/830193002) used to always read Chromoting policies from the registry. The new code (using components/policy) ignores contents of the registry on non-domain-joined machines. This old-vs-new difference in behavior was unintentional. The current changelist ensures that Chromoting's old behavior is preserved. BUG=460734 TEST=1) components_unittests.exe, 2) remoting_unittests.exe, 3) remoting_unittests.exe --gtest_filter=*PolicyWatcher*Real* -v=1 copied and run from a non-domain-joined, test VM to verify that Chromoting gets its policies from the registry (HKLM\SOFTWARE\Policies\Google\Chrome) in this scenario. Review URL: https://codereview.chromium.org/947353002 Cr-Commit-Position: refs/heads/master@{#317865} (cherry picked from commit bccb49e) TBR=dcaiafa Review URL: https://codereview.chromium.org/959033002 Cr-Commit-Position: refs/branch-heads/2311@{#40} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
This is temporary, so we can avoid gl circular dependency. Eventually, we want to be as aligned as possible with upstream Media solution and need to figure out how we could use upstream VaapiWrapper (while able to generate custom va_stubs if possible?). (This is oz-wl's 0005-Media-Build-VaapiPictureWayland-as-part-of-Media.patch).
This patch includes Chromium side changes that are needed for integrating WebMediaPlayer with the Murphy resource policy daemon.
We support notifications in Android but upstream doesn't so we should make sure they are enabled. We should really consider if the "desktop" notifications are the way forward for us in Android now that we have ServiceWorker and push notifications. https://codereview.chromium.org/920153002 BUG=XWALK-3653
Buffer swapping should not be synchronized so that the GPU process is not blocked by waiting for a frame update from Weston. BUG=TC-341 (This is oz-wl's 0008-Fix-crash-when-switching-to-console-VT-mode.patch.) It is not clear from ozone-wayland's pull request #300 if this change has been submitted upstream.
…er APIs vaLockBuffer APIs are obsolete. This change will use vaAcquireBufferHandle APIs to instead of vaLockBuffer APIs. VA-API version: >= 0.36 (libva 1.4.0) (This is ozone-wayland's 0012-Use-vaAcquireBufferHandle-APIs-to-instead-of-vaLockB.patch)
(This is ozone-wayland's 0013-Media-Use-upstream-Video-Accelerator.patch)
The ICU 54.1 upgrade added a call to uloc_getDefault() to base/test/test_suite.cc, but did not add a libicuuc dependency to the corresponding gyp/gn targets. This makes it possible to mix system and bundled ICU headers (and will fail to build if they differ in version). BUG=428145 Review URL: https://codereview.chromium.org/943233002 Cr-Commit-Position: refs/heads/master@{#317616}
Requiring users to manually download Android SDK Extras is a step backwards for automation. We do not use them in Crosswalk or in our content_shell builds, so for now simply make things work without these files: * Make download_sdk_extras.py do nothing instead of timing out, as Crosswalk's bots set CHROME_HEADLESS=1 but the files this script tries to fetch are only accessible from Google's network. * Make the calls to find(1) in java.gypi create the directories before entering them. This is what was causing gyp to fail before even if we never depended on the targets requiring the SDK Extras ourselves. Hopefully we can work together with upstream to make the situation easier to manage.
…s://codereview.chromium.org/857483004/) Reason for revert: This is breaking a lot of things (He's dead jim pages, extensions, and other things). See issue 462026. Original issue's description: > Enable ChannelMojo > > As we addressed certain amount of the performance problem, > it's time to give it another try. > > [email protected] > BUG=377980 > > Committed: https://crrev.com/a06cd1b2fe83b51b0874ca504066f00a17192026 > Cr-Commit-Position: refs/heads/master@{#313184} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=377980 Review URL: https://codereview.chromium.org/1002973002 Cr-Commit-Position: refs/heads/master@{#320394}
[Backport] Revert of Enable ChannelMojo (patchset #3 id:40001 of https:/...
Use this API to control whether the SurfaceView's surface is placed on top of its window. Note this only works when SurfaceView is used. For TextureView, it doesn't work. Related to XWALK-3778,XWALK-3742
In Android, copy/paste picture only isn't being good supported. In chromium for Android, it supports copy/paste text with picture. In order to align with Android, chromium for Android disabled copy/paste picture only previously. But copy/paste picture only and text with picture among chromium for Android and Android native applications behave the same. So we enable copy/paste picture only. BUG=XWALK-3764
|
Testing patch series with axinging/chromium-crosswalk@5dc950dfd897c45bc83f7250760b8be1eeb66ee5 as its head.
|
|
@halton @lincsoon @kenchris @darktears |
| // available, because otherwise others apps may not be able to paste it. | ||
| if (!ContainsKey(map_, kPlainTextFormat)) | ||
| return; | ||
|
|
There was a problem hiding this comment.
I think customer complain that this bug appear on chrome on Android as well, not sure it is suitable to fix it on upstream.
If upstream does not want support this, as for how to fix it. Can we add the key kPlainTextFormat in crosswalk?
There was a problem hiding this comment.
I have submitted a bug here at chromium: https://code.google.com/p/chromium/issues/detail?id=469565
|
Since this also affects Chromium upstream and is not a P1 bug, I'd like to wait for them to provide some feedback and only then proceed with changing our version if necessary. |
rakuco
force-pushed
the
master
branch
3 times, most recently
from
1de2acc to
4c51f84
Compare
|
@axinging please rebase your code. |
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
OS X sometimes returns an empty certificate chain on unrecoverable certificate chain. This was leaving the verified certificate NULL and causing crashes. BUG=472291 Review URL: https://codereview.chromium.org/1094983002 Cr-Commit-Position: refs/heads/master@{#326683} (cherry picked from commit a6173cd) This also includes https://codereview.chromium.org/1102673006 which adds a valgrind suppression for a memory leak in Apple's code that the tests expose. [email protected] Review URL: https://codereview.chromium.org/1111463003 Cr-Commit-Position: refs/branch-heads/2357@{#240} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco
pushed a commit
that referenced
this pull request
Aug 13, 2015
The TabContentManager was being garbage collected before migration finished, resulting in native background threads attempting to execute JNI on the dead TabContentManager. More explicitly hold the TabContentManager inside of the FaviconImageCallback (even though it was already doing so) as a member field instead, which seems to prevent the GC from nuking it. Possible reasoning on why the GC was being irrationally exuberant: http://stackoverflow.com/questions/26642153/finalize-called-on-strongly-reachable-object-in-java-8 BUG=513130 Review URL: https://codereview.chromium.org/1260043007 Cr-Commit-Position: refs/heads/master@{#341971} TBR=dtrainor Review URL: https://codereview.chromium.org/1277593003 . Cr-Commit-Position: refs/branch-heads/2454@{#240} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
We don't know for sure whether sync will succeed at starting up at initialization time, but we can inspect and report on the state of various flags. BUG=555113 Review URL: https://codereview.chromium.org/1463583008 Cr-Commit-Position: refs/heads/master@{#362455} (cherry picked from commit 33a3aac) Review URL: https://codereview.chromium.org/1499903004 . Cr-Commit-Position: refs/branch-heads/2564@{#240} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
> [DevTools] Allow source maps from the file system. > > BUG=580693 > > Review URL: https://codereview.chromium.org/1647773005 > > Cr-Commit-Position: refs/heads/master@{#372459} (cherry picked from commit 9272dcc) TBR=pfeldman Review URL: https://codereview.chromium.org/1657923003 . Cr-Commit-Position: refs/branch-heads/2623@{#240} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=590648, 593435 Review URL: https://codereview.chromium.org/1791443002 Cr-Commit-Position: refs/heads/master@{#380978} (cherry picked from commit 1d2c4fd) Review URL: https://codereview.chromium.org/1807553002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#240} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later. BUG=616683 Review-Url: https://codereview.chromium.org/2029963002 Cr-Commit-Position: refs/heads/master@{#397481} (cherry picked from commit cdf25cc) Review URL: https://codereview.chromium.org/2040003002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#240} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
crrev.com/c/515606 overly simplified table layout overflow which is expected to cover all collapsed border overflows. The CL added all visual overflow into layout overflow causing it to also unexpectedly cover all contents overflows (e.g. shadow and outlines of descendants). Fix the issue by just include collapsed border overflow. [email protected] (cherry picked from commit b5eb082) Bug: 763337 Change-Id: I6c53afba3f00729a483588dfea46c86a8b78562a Reviewed-on: https://chromium-review.googlesource.com/657815 Commit-Queue: Xianzhu Wang <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#501201} Reviewed-on: https://chromium-review.googlesource.com/667744 Reviewed-by: Xianzhu Wang <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#240} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android, copy/paste picture only isn't being good supported.
In chromium for Android, it supports copy/paste text with picture.
In order to align with Android, chromium for Android disabled
copy/paste picture only previously.
But copy/paste picture only and text with picture among chromium
for Android and Android native applications behave the same.
So we enable copy/paste picture only.
BUG=XWALK-3764